commit 1477b21c5eb3487043e3d2a1f2350dd14b41fb2e Author: Julian Maurice Date: Wed Oct 9 22:03:16 2024 +0200 Bug 38136: Refactor database translations (alternative) This has the same goals of bug 24975 but with a different approach. Bug 24975 tried the "POT/PO files as database tables" approach but it appeared that is not what best fits our needs. Instead of a "source text / translated text" mapping, we need translations to be attached to a specific "object" (or table row), which has the added benefit of keeping translations unaffected when the original string changes. It may or may not be what you want but at least this avoids the problem where fixing an error in the original string forces users to re-translate everything. We also need to be able to translate all translatable properties of a particular entity. The solution proposed here is to add a DBIC component that will add several DBIC relations to the `localization` table: * a relation named `localizations` that will return all translations for all translatable properties for all languages. * for each translatable property: * a relation named `{$property}_localizations` that will return all translations for a given property, for all languages * a relation named `{$property}_localization` that will return the translation for a given property, for the current language To enable translations for a particular entity, we will need to: * add two method calls in the "result class" corresponding to the localizable object type * in the admin interface, add a link to the the translation popup. Unlike bug 24975 there is not a page where you can translate everything. I don't know if it is really useful (probably better to translate itemtypes when you are on the itemtype page). It can be added later if needed. To give an example, this is what needs to be added manually in Koha/Schema/Result/Itemtype.pm: __PACKAGE__->load_components('+Koha::DBIx::Class::Localization'); __PACKAGE__->localization_add_relationships( 'itemtype', # the PK column 'description' # a list of translatable columns ); (see POD in Koha/Schema/Component/Localization.pm for more information) Final notes: * I wanted this patch to have as few changes as possible so I kept methods like `search_with_localization`, `children_with_localization` even if I believe they can be removed (replaced by search/children) Localizations do not need to be prefetched/joined unless you want to sort on them. For the same reason, $itemtype->unblessed now always return a `translated_description` key. This can be fixed in followup patches * There is cache involved (see Koha::Schema::Component::Localization::localization). Localizations in cache are grouped by object type and language (keys look like 'KOHA:localization:Itemtype:en') * By keeping a single table for all translations of all entities, we cannot have data integrity at the RDBMS level, but automatic deletion of translations is handled by the DBIC `cascade_delete` feature, so integrity should be fine as long as no raw SQL update/delete operation is involved. commit 38d9b0d11078549ec673987a116088ebcf5016d8 Author: Martin Renvoize Date: Tue Mar 25 15:00:14 2025 +0000 Bug 39447: Update mailmap to reflect PTFS-Europes rename PTFS Europe is now officially Open Fifth Signed-off-by: Martin Renvoize Signed-off-by: Paul Derscheid Bug 39447: (follow-up) Corrections to existing mappings I thought it worked through from top to bottom and thus the lower down mappings would correct the higher up ones.. I was mistaken, thanks Jonathan for pointing that out Test with: 1. `git shortlog --summary --numbered --email | grep ptfs-e` 2. `git shortlog --summary --numbered --email | grep openfifth` Amended-by: Jonathan Druart Space adjustements Signed-off-by: Jonathan Druart commit bfd593946852ec859052a61d10962f6f59b658b0 Author: Jonathan Druart Date: Mon Mar 24 10:31:41 2025 +0100 Bug 37273: Fix Cypress tests Signed-off-by: Jonathan Druart commit 31789383aa25aa2f2a8da77318dcf383b12794d9 Author: Martin Renvoize Date: Fri Mar 21 12:43:13 2025 +0000 Bug 38087: (follow-up) Add missing div to template We lost a closing div somewhere during the life of this patchset Signed-off-by: Katrin Fischer commit ede4088d7a082dcb4ab7de3b399b7b9b2858d506 Author: Martin Renvoize Date: Fri Oct 4 12:45:07 2024 +0100 Bug 38087: Add print template for WELCOME notice at install time This patch adds a default print template for the welcome notice. It will be installed at install time but will not be added at upgrade time. It will also be available as the default under the notice templates tool. Test plan 1) Apply the patch 2) Under 'Tools > Notices and Slips' select the 'WELCOME' notice to edit 3) Click 'View default' under the 'Print' message transport type 4) Note the new default template is shown 5) Use 'Copy to template' to apply it to the notice 6) Use a user (Henry perhaps under sandboxes) without an email address to test the template by 6a) Under 'more' click 'Send welcome notice' 7) Preview the pending print notice under the patrons notices tab by clicking the notice title. 8) Confirm the notice looks reasonable and sign off Signed-off-by: Laura_Escamilla Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 207cb5924101c1807e584df21000acfec3a1a8e7 Author: Owen Leonard Date: Fri Mar 14 17:52:08 2025 +0000 Bug 31167: Only mark due dates in the past red on overdues report This patch adds information about whether an entry in the overdue report is overdue so we can style dates accordingly. We can't assume that each result is overdue because the report can be changed to include all checked out items. To test, apply the patch and go to Circulation. - Check out to a patron. - Use the "Specify due date" option to check out some items with due dates in the past, due dates today, and due dates in the future. - Go to Circulation -> Overdues. - You should see the items which have due dates in the past. The date in the "Due date" column should be red text. The "Checked out on" date should be regular text. - In the sidebar, check the "Show any items currently checked out" checkbox and submit the form. - You should now see all the items you just checked out. Only the overdue items should show their due date in red. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 3888d1ee7ac51b131f22f00fbe732eb23c75eccc Author: Lucas Gass Date: Tue Mar 11 16:57:47 2025 +0000 Bug 39283: Concat middle name with preffered name if it exists 1. Have a patron with a middle name 2. Do a patron search that brings them up, no middle name appears 3. APPLY PATCH 4. Try again, middle name should appear in patron searches. QA follow-up: made the same fix inline for other_name Signed-off-by: Bibliothèque Ifao Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 4f170fb94d351577eba4f3463de025830426992f Author: Lucas Gass Date: Fri Mar 14 22:28:37 2025 +0000 Bug 39331: If patron category cant be guarantee do not continue with add_guarantors To test: 1 - Remove age limits from a Child and Adult category in Administration->Patron categories. Ensure Child category can be guarantor and Adult cannot 2 - The above step is to avoid any age checks and form resubmission which removes the guarantor fields 3 - Find/create a child patron 4 - Add a guarantee from the Adult category to the child 5 - Check the DB: SELECT * FROM borrower_relationships WHERE guarantee_id={borrowernumber of child}; 6 - Note the id colum 7 - Edit the child patron to Adult category 8 - Repeat 5 9 - Note the relationship still exists and the id is incremented 10 - Oof! 11 - APPLY PATCH, restart_all 12 - Try again steps 3 - 8 13 - The relationship should not be re-added 14 - Try with more than 1 guarantor on the record, confirming all are deleted 15 - Try adding some guarantor to patron types that should be able to, they relationship should work. 16 - Try changing some patrons to categories that do allow guarantors, making sure the relationship does stay. Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 6e4039b72ad7294c48ece116a10db493b4d1aafa Author: Jonathan Druart Date: Thu Mar 20 15:28:55 2025 +0100 Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification We built select_class but never used it. Test plan: Go to Batch item modification and confirm that the select2 dropdown lists are no longer empty Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 4eececb3305b5a5093ca98d8515cccc7b85d57a1 Author: Jonathan Druart Date: Wed Mar 12 15:44:11 2025 +0100 Bug 38981: Directly use the opac-image link Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 545ff24dd0e7858abe940884fb77088e8ac79ba9 Author: Owen Leonard Date: Tue Mar 11 15:07:27 2025 +0000 Bug 38981: Local cover images failing to load in OPAC search results This patch uncomments some code which was incorrectly left commented after debugging. Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit a629a518f529a3f5849ab5b0d463ab8f242b98f2 Author: Katrin Fischer Date: Thu Mar 20 16:07:20 2025 +0000 Bug 38494: DBRev 24.12.00.020 Signed-off-by: Katrin Fischer commit ebba76f1b75ee26f8dca21c240f936b144d7750b Author: Janusz Kaczmarek Date: Thu Mar 20 15:16:49 2025 +0000 Bug 38494: (follow-up) Text amendments clarifying that it is about MARC21 records Refers to ConsiderHeadingUse and ShowHeadingUse systempreferences. Signed-off-by: Katrin Fischer commit f307624049b3a1347f5dc4ebd0d85cfa6e449aac Author: Marcel de Rooy Date: Fri Mar 14 10:04:16 2025 +0000 Bug 38494: (QA follow-up) Add comment and extend pref desc See BZ comment18. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 4330e1f51479d1e836911cae46c09eae5657e1aa Author: Janusz Kaczmarek Date: Wed Nov 20 13:18:05 2024 +0000 Bug 38494: Koha should consider authority heading use in cataloging In MARC 21 authority records, three bytes (008/14-16) indicate what the heading can be used for (main/added entry, subject entry, series entry). Koha should be able to respect the record's intended use in authority search during cataloging, provided that the authority file is well formed. Also, we should be able to decide between more strict but correct behavior and current lax behavior. Test plan: ---------- 1. Apply the patch; updatedatabase ; restart_all 2. Set the ShowHeadingUse system preference to ‘Show’ 3. Go to the Cataloging editor and open the authority finder plugin for the 100 field. Search for Peter. With standard ktd test data you should get 9 results, some with ‘v’ before Main/Added Entry, some with ‘x’. These with ‘x’ are not to be used in this context, provided you use a well-formed authority file 4. Set ConsiderHeadingUse system preference to ‘Do’ 5. Repeat p. 3. You should get now only 4 Peters – those with ‘v’ before Main/Added Entry (008/14 = ‘a’) 6. You can repeat the test for subject headings (6XX) and series headings (sometimes you would have to modify the test data, e.g. there are few authority records with 008/16 = ‘a’ (series use) 7. This should work equally with Zebra and with Elasticsearch Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 70138465cd434584d2a216d42fca93ae82d1a619 Author: Janusz Kaczmarek Date: Wed Nov 20 13:15:43 2024 +0000 Bug 38494: Add 'ConsiderHeadingUse' system preference Add new system preference 'ConsiderHeadingUse' to be able to consider the intended use of authority records (008/14-16) during cataloging and linking. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit c30559349a13402a0abe7a0c2780c77b7f5247c0 Author: Jonathan Druart Date: Thu Mar 20 16:44:29 2025 +0100 Bug 26553: Fix kohaTable call in TrainsShow It's the only occurrence in Vue components Signed-off-by: Katrin Fischer commit 767b5be9451cfd9c4479f7c3ad877e2341646648 Author: Jonathan Druart Date: Thu Mar 20 16:39:30 2025 +0100 Bug 38993: Send CSRF token for Vue fetches We need it for syspref at least. Signed-off-by: Katrin Fischer commit 2fc1b5f825b0a4713fa1986cce024fb5ffd77acd Author: Jonathan Druart Date: Thu Mar 20 12:07:04 2025 +0100 Bug 38993: Fix sysprefs fetch from cypress Conflict between bug 38993 and bug 36025 We pass the token in the header, and retrieve it from the meta tag. Signed-off-by: Katrin Fischer commit cfb5d05ed948cfa07042a579dc17b645e4d09ead Author: Phil Ringnalda Date: Wed Mar 12 10:06:37 2025 -0700 Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an , but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library Signed-off-by: Andrew Fuerste Henry Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 36f86bacb06948f67f63bb317b58a3e24300309a Author: Owen Leonard Date: Fri Mar 14 12:21:08 2025 +0000 Bug 38184: (follow-up) Correct the number of tests Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 53c58f7cefc93c7915965c19334b3ee47fba8a58 Author: Aleisha Amohia Date: Thu Mar 13 23:34:23 2025 +0000 Bug 38184: Show due date on OpacTrustedCheckout modal This fixes checkout fields being made available to the public API. Note: This depends on the fix at Bug 39313, so make sure you apply that first. To test: 1. Enabled OpacTrustedCheckout system preference 2. Search for an item and get the barcode 3. Go to the OPAC 4. Click the Self-checkout button at the top 5. Enter the barcode and submit 6. Notice that the due date does not show in the modal, even though the due date was correctly set 7. Apply the patch and restart services 8. Go to the staff interface and check in your barcode 9. Repeat steps 3-5 10. Confirm the due date does show correctly in the modal 11. Confirm tests pass t/db_dependent/Koha/Checkout.t Sponsored-by: Reserve Bank of New Zealand Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 35d100413da4677ab6cc133c93478f9ae90f2e78 Author: Martin Renvoize Date: Tue Mar 18 09:21:17 2025 +0000 Bug 32604: Unit tests Add unit tests to more thoroughly and specifically cover the search_patrons_to_update_category method including specific date handling tests. We also add some notes to the POD that were highlighted by writing comprehensive tests. Signed-off-by: Martin Renvoize Signed-off-by: Emmi Takkinen Signed-off-by: Katrin Fischer commit 7fbeba8b75f074ba3972b4b1f5fcf2b3aa0409c7 Author: Bernard Scaife Date: Mon Mar 17 18:07:02 2025 +0000 Bug 32604: Correct boundary calculation for birthdate Add 1 to upperagelimit to make it calculate birthday boundaries correctly for patrons_to_update_category search To test: 1. Add upper age limit as 18 for child patron category. 2. Create a child patron whose age is 18. 3. Save. => Patron is saved successfully. 4. Run cronjob update_patrons_category.pl with verbose option. perl update_patrons_category.pl --too_old --from CHILD --to ADULT -v => Note that patron is reported as updated (or would have updated) as an adult patron. 5. Apply patch 6. Re-run steps 1 to 5 and note we no long update the 18 year olds. Signed-off-by: Martin Renvoize Signed-off-by: Emmi Takkinen Signed-off-by: Katrin Fischer commit b1a326238acf870b982b3acac61346357077e7c1 Author: Lucas Gass Date: Tue Feb 25 23:22:14 2025 +0000 Bug 35134: Use localStorage instead of a cookie Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit da66e8ac83463d2be39e754a73f42b95cedf6482 Author: Pedro Amorim Date: Tue Apr 23 12:11:59 2024 +0000 Bug 35134: Save popup size to cookies and use that instead Follow the original test-plan, open the pop-up and resize to whatever size. Close the pop-up, open again, notice it opens to the same size it was previously closed. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit d50baeabacbd1a8066e730a7626ce4045f50c596 Author: Lucas Gass Date: Tue Nov 21 15:26:13 2023 +0000 Bug 35134: Make cn_browser popup responsive to screen size To test: 1. Use the cn_browser.pl plugin for the 952$o ( call number ) 2. Add or edit an item and select the `...` to the right of the call number field. 3. The pop-up is hardcoded as 500px x 400px pop-up. 4. APPLY PATCH 5. Clear browser cache and try again. The window width should now be half of the current screen size. The window height should be 100% of the screen height. Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit e303854076d60a5a2abc9c50c21e1945c7b542ba Author: Hammat Wele Date: Mon Mar 20 21:44:10 2023 +0000 Bug 33224: OPACHoldsIfAvailableAtPickup and no on-shelf holds don't mix well When OPACHoldsIfAvailableAtPickup preference is set to Don't allow and circulation rules allow on-shelf holds only if any unavailable, and we have a record with a checked out copy at Centerville and an available copy at Midway, a Midway patron should not be able to place a hold for pickup at Midway since the Midway copy is available. This is the setting: - circulation rules allow on-shelf holds only if any unavailable - OPACHoldsIfAvailableAtPickup is set to Don't allow To test: 1. Set up the circulation rule so that on-shelf holds are allowed ('Yes') 2. Create a record with two items, one at Centerville and one at Midway 3. Check out the Centerville item 4. Log into the OPAC with a Midway patron (I used Henry Acevedo) 5. Try to place a hold on the record --> Midway is not a valid pickup location (correct behaviour) 6. Cancel 7. Change the circulation rules so that on-shelf holds are only allowed 'if any unavailable' 8. Try to place a hold on the record from the OPAC again --> The system allows you to place the hold for pickup at Midway (incorrect behaviour) 9. Optionally, check the Holds to pull for Midway (the hold is there, it shouldn't) 10. Optionnaly, check in the Midway item (it is trapped for Henry's hold) 11. Apply the patch 12. Try again to place a hold on the record from the OPAC --> it is impossible to select Midway, Midway is not a valid pickup location Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 8ae546b31b685ff4daaf979a20afdb58960c3595 Author: Emily Lamancusa Date: Wed Mar 19 10:49:45 2025 -0400 Bug 39353: (QA follow-up) Clarify error message Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 488d0042e665ad82b6d25a87da32fba396779c20 Author: Jonathan Druart Date: Mon Mar 17 11:00:39 2025 +0100 Bug 39353: Prevent tidy.pl to empty template files In ktd context: if host's node_modules ktd has been generated prior to bug 38644, the template-toolkit's prettier plugin is not there and prettier will empty the file. It seems to be a prettier bug, and the following behaviour is confusing: From the host: % yarn run prettier --write koha-tmpl/intranet-tmpl/prog/en/modules/test.tt yarn run v1.22.22 $ prettier koha-tmpl/intranet-tmpl/prog/en/modules/test.tt [error] Cannot find module '@koha-community/prettier-plugin-template-toolkit' [error] Require stack: [error] - /home/jonathan/workspace/koha/node_modules/prettier/index.js [error] - /home/jonathan/workspace/koha/node_modules/prettier/cli.js [error] - /home/jonathan/workspace/koha/node_modules/prettier/bin-prettier.js error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. => The file is not modified Within ktd: $ yarn run prettier --write koha-tmpl/intranet-tmpl/prog/en/modules/test.tt yarn run v1.22.22 $ prettier --write koha-tmpl/intranet-tmpl/prog/en/modules/test.tt koha-tmpl/intranet-tmpl/prog/en/modules/test.tt 6ms Done in 0.39s. => No error, and the file is emptied! It seems that the plugin is found by prettier but not used (?) Test plan: 1. Follow this from step 1 to 14 https://gitlab.com/koha-community/koha-testing-docker/-/issues/483 2. Apply patch 3. misc/devel/tidy.pl --no-write koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt It should print the new error message 4. Make a change to a .tt file, commit 5. There will be a message about and issue with prettier. But it will still commit. It's expect. 6. Inspect and see that the commit has the changes Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 8e0d00dd76890fde17e25661ebd870f94aa22021 Author: Jonathan Druart Date: Wed Mar 19 15:42:01 2025 +0100 Bug 38944: Tidy t/db_dependent/Record/Record.t The generated patch was big and I skipped the git hook :-/ Signed-off-by: Katrin Fischer commit cb71027f141d46c1f26f57f6db299dcc197ed9b0 Author: Martin Renvoize Date: Wed Nov 6 11:18:22 2024 +0000 Bug 37171: Add serial note to serial claims screen This patch adds the serial note field into the serials claims display table. Test plan: 1) Add a Serial 2) View the serial 'Serial collection' 3) Use the 'Edit serials' option to add a note to an expected, late serial issue. 4) View the serial claims for the Vendor of that serial 5) Note the new 'Serial notes' column in the display of claims 6) Signoff Sponsored-by: Loughborough University Signed-off-by: Martin Renvoize Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 0f077950fcac2c01b3fb9b3a22812b053e8018a1 Author: Aleisha Amohia Date: Tue Jun 13 22:15:13 2017 +0000 Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled - BakerTaylorBookstoreURL To test confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard I'm not able to test Syndetics but everything else works correctly. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 84c5e81b0760ad41d147c4e0e68158f8a7d025f9 Author: Martin Renvoize Date: Tue Mar 18 15:31:15 2025 +0000 Bug 38663: (follow-up) Make database update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3c6b7ae201e59303d9a9c2b4ac7cb5645d3d9bda Author: Lari Taskula Date: Thu Mar 6 13:33:44 2025 +0000 Bug 39265: Hide library drop-down from opac-memberentry if there is only one library To test, apply the patch and enable PatronSelfRegistration. - Modify the PatronSelfRegistrationLibraryList system preference to include only one library. - Go to the self-registratoin page in the OPAC. - Under "Home library," you should see the library name. If you inspect the source you should see the library branchcode in a hidden form. - Confirm that the form submission includes the correct library information. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 0be7d23b4ca79a93f555230b9cb1b4724d88e387 Author: Nicolas Hunstein Date: Fri Feb 28 13:32:58 2025 +0000 Bug 39005: update the explanatory message of Force new patron password reset in the patron category form updates explanatory message "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" to "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" to test: - go to Administration page - go to patron categories - open the patron category form for example by clicking on "New category" - check there is the string "Choose whether staff created patrons of this category be forces into resetting their passwort after their first OPAC login" - apply patch - verify there is the string "Choose whether staff-created patrons of this category are forced to change their password after their first OPAC login" now Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 6c95ae68be05cf841a6ec5dfbfad043e9df6be95 Author: Owen Leonard Date: Tue Mar 18 11:36:19 2025 +0000 Bug 39354: (follow-up) Override additional BS5 CSS for multiple-select Signed-off-by: Katrin Fischer commit 09c79110a11e5d336734357328c858b3245c271b Author: Owen Leonard Date: Mon Mar 17 10:26:21 2025 +0000 Bug 39354: Remove unintended Bootstrap 5 change to scroll-behavior This patch updates the "variables" SCSS file in the OPAC and staff interface in order to disable the "smooth scroll" behavior introduced in Bootstrap 5. This was an unexpected and unintentional change. The patch also corrects another unexpected side-effect of the BS5 upgrade: A change to the "cursor" property of elements with a ".placeholder" class. This class is used by the multiple-select jQuery plugin found in some system preference controls. To test, apply the patch and rebuild the staff and OPAC CSS. - Clear your browser cache if necessary. - In the staff interface, go to Administration -> System preferences -> Circulation, and click "Patron restrictions" in the left-hand sidebar. The page should jump immediately to that section without any scrolling effect. - Go to the "Article requests" section of that page. Hover your cursor over a dropdown which doesn't have any option selected. Your cursor should not change to a "waiting" cursor. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 37c8c6606ae7d4531c2e8722d8dd57566f1ded84 Author: Lucas Gass Date: Fri Mar 7 00:02:30 2025 +0000 Bug 39270: Check to make sure checkouts are not already booked To test: 1. Find an item that is bookable, I turned on Bookable at the item type level for BK. I am using biblionumber=28 in k-t-d with 3 items 2. Book item with barcode ( 39999000001297 ). I did March 7 - April 1 3. Book item with barcode ( 39999000001259 ). I did March 7 - April 1 4. Now checkout 39999000001297 to the patron is was booked to. When asked about early collection say yes. 5. Now item with barcode ( 39999000001273 ) is not checked out or booked. It should be bookable 6. Try to book it, it is not available till April 2, though it should be available right now. 7. APPLY PATCH 8. Try the bookings again. 9. You should correctly not be able to book 39999000001297 or 39999000001259. 10. You should be able to book 39999000001273. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 1045dc122424654be78732f9ccbd4459b47e02eb Author: Owen Leonard Date: Mon Mar 17 12:27:22 2025 +0000 Bug 39357: Wrong sidebar menu on batch checkout page This patch updates the batch checkout page template so that it shows the patron detail sidebar instead of the circulation navigation sidebar. To test, apply the patch and enable BatchCheckouts if necessary. - Open a patron record for checkout. - Click "Batch check out" in the left-hand sidebar. - The sidebar should show patron details and links like "Check out," "Details," etc. Sponsored-by: Athens County Public Libraries Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 7dc5f0903086cddde67bd474826d002e656df3a6 Author: David Gustafsson Date: Thu Mar 13 19:36:03 2025 +0100 Bug 39334: (follow-up) Preserve order when adding patron attributes To test: 1) Run tests in t/db_dependent/api/v1/patrons_extended_attributes.t, serveral should fail 2) Apply patch 3) Run the tests in 1) again, all should now pass Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit ab2c6929228aca3d921525405100ee305efd6669 Author: Owen Leonard Date: Mon Jul 22 14:26:27 2024 +0000 Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c94c27ea344aa473ef50b3bd20ea9904bd694cd0 Author: Owen Leonard Date: Mon Jul 1 11:23:58 2024 +0000 Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit f6ed6fc62ba9a2b19555b43f2c03e7e5cbaa9177 Author: Victor Grousset Date: Tue Feb 18 01:49:24 2025 +0100 Bug 39130: (QA follow-up): Ignore useful untidy part of sample.tt And fix a minor legit tidy issue above. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 6fcca08f41426588e434ff206a0f4e076ea5c7c5 Author: Julian Maurice Date: Thu Feb 13 14:26:55 2025 +0100 Bug 39130: Add unit tests for xgettext.pl Test plan: 1. Run `prove t/db_dependent/misc/translator/xgettext.pl.t` Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit d85c6ec0b4584f41a6692d88dfe778a1cfa6640e Author: Jonathan Druart Date: Thu Jan 30 10:06:18 2025 +0100 Bug 38993: Restore add patrons to list Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 72c45bd209a5faed91fca6095e5c146fbaa6511d Author: Jonathan Druart Date: Thu Jan 30 09:15:12 2025 +0100 Bug 38993: Use the @fetch alias Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 27524f87e34d0ddbd912b995202ed414b769fb05 Author: Paul Derscheid Date: Wed Jan 29 16:34:31 2025 +0000 Bug 38993: (follow-up) Add 'fetch' alias to rspack config Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 8bfb9451bfcd57da69cb838a79f5b843c0e21b24 Author: Jonathan Druart Date: Wed Jan 29 17:04:08 2025 +0100 Bug 38993: Merge 'fetch' directories Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 8f65d7f2bec2ac21e0eccfe62a3d6a560a37a41e Author: Lucas Gass Date: Thu Jan 16 14:54:48 2025 +0000 Bug 15461: Fix typo in items/catalogue_detail.inc Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer